Define NOMINMAX in z_pull to use std::max #135
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the
z_pull_zenohc
example fails on Visual Studio 2022 with the error:The problem is that including
windows.h
defines themax
preprocessor macro, that interferes with the subsequent use ofstd::max
. By definingNOMINMAX
, nomax
macros is defined.With this and #134, all the
zenohc
based examples compile fine on Visual Studio 2022 (xref: #5), while thezenohpico
one are still failing.